search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 493 forks source link

RageShake can be refused by back-end if attached log files are too big #7559

Closed NicolasBuquet closed 1 year ago

NicolasBuquet commented 1 year ago

Steps to reproduce

When you are using Tchap for a few months, logs can become quite big. These logs can be attached to a rageShake and transmitted as a zip file to back-end. This zip file can quickly become bigger than 20MB.

Outcome

Depending on the configuration of the back-end, big attachement files can be refused and then the RageShake is refused (error 500).

Actually, it is the matrixSDK which handles this. It accepts a flag telling him to attach teh log files or to not attach them.

This parameter could be replaced by a maximum attachment size which could be 0 if no attachment is wanted.

Your phone model

No response

Operating system version

No response

Application version

Element 1.10.11

Homeserver

Tchap

Will you send logs?

No

pixlwave commented 1 year ago

@NicolasBuquet MXLog can be configured with a maximum files size, I think this is what you're looking for: https://github.com/vector-im/element-ios/blob/2bd099eb5d26110b9e4b503f105a969b014d43cf/Riot/Modules/Application/LegacyAppDelegate.m#L269

NicolasBuquet commented 1 year ago

Thank you @pixlwave You're right, that's the parameter I was missing to limit the storage size of the whole log files.