element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 493 forks source link

Broadcast Upload Extension #7566

Closed Velin92 closed 1 year ago

Velin92 commented 1 year ago

This allows to screen share your screen by using Jitsi screen share feature.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (94d19d4) 12.36% compared to head (3c5bae9) 12.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7566 +/- ## =========================================== - Coverage 12.36% 12.22% -0.15% =========================================== Files 1648 1648 Lines 163581 163591 +10 Branches 67170 67156 -14 =========================================== - Hits 20226 19992 -234 - Misses 142690 142954 +264 + Partials 665 645 -20 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.05% <ø> (-0.01%)` | :arrow_down: | | unittests | `6.06% <0.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...s/Integrations/Widgets/Jitsi/JitsiViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0ludGVncmF0aW9ucy9XaWRnZXRzL0ppdHNpL0ppdHNpVmlld0NvbnRyb2xsZXIubQ==) | `0.00% <0.00%> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7566/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XLD51y

Velin92 commented 1 year ago

The PR is ready the only thing left to do is understand how to deal with the copyright notices, considering that the SDK guide itself suggested to import the files, and that the original repo has the following Apache LICENSE https://github.com/jitsi/jitsi-meet-sdk-samples/blob/master/LICENSE

I did some modifications in the SampleHandler but nothing too major in the other files.

@manuroe

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information