element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 493 forks source link

Increase max. length of voice message recordings to 5m #7582

Closed Johennes closed 1 year ago

Johennes commented 1 year ago

I tested this on an iPhone X and the experience felt acceptable. When recording a 5m voice message, it took two or three seconds for it to display in the timeline after pressing the send button. This isn't particularly great UX but struck me as acceptable given that the current limit appears to be quite limiting for parts of our user base (see the discussion in #5415). @jakewb-b curious if you'd be ok with this.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.02 :tada:

Comparison is base (1e5809d) 12.34% compared to head (1167086) 12.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7582 +/- ## =========================================== + Coverage 12.34% 12.36% +0.02% =========================================== Files 1648 1648 Lines 163634 163637 +3 Branches 67188 67194 +6 =========================================== + Hits 20204 20238 +34 + Misses 142765 142734 -31 Partials 665 665 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.06% <ø> (+0.01%)` | :arrow_up: | | unittests | `6.21% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...es/Room/VoiceMessages/VoiceMessageController.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1Jvb20vVm9pY2VNZXNzYWdlcy9Wb2ljZU1lc3NhZ2VDb250cm9sbGVyLnN3aWZ0) | `0.00% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7582/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jacotec commented 1 year ago

Highly appreciated from my side! 5 minutes may calm down users a bit while waiting for Element-X ;-)

Johennes commented 1 year ago

@jacotec the next release is currently scheduled for the week of June 19th.