element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

direct chat invite crashes the app #7583

Closed toshanmugaraj closed 1 year ago

toshanmugaraj commented 1 year ago

…@gmail.com

Pull Request Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e30eaf) 12.36% compared to head (08d411b) 12.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7583 +/- ## ======================================== Coverage 12.36% 12.36% ======================================== Files 1648 1648 Lines 163634 163636 +2 Branches 67192 67193 +1 ======================================== + Hits 20232 20235 +3 + Misses 142737 142736 -1 Partials 665 665 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `6.21% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1Jvb20vVmlld3MvV1lTSVdZR0lucHV0VG9vbGJhci9XeXNpd3lnSW5wdXRUb29sYmFyVmlldy5zd2lmdA==) | `0.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7583/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jacotec commented 1 year ago

@toshanmugaraj Will this probably fix #7577 ?

toshanmugaraj commented 1 year ago

@toshanmugaraj Will this probably fix #7577 ?

yes it fixes

jacotec commented 1 year ago

What is the issue? I have a couple of users who can't open a new chat ... is there a workaround until your fix is live?

toshanmugaraj commented 1 year ago

What is the issue? I have a couple of users who can't open a new chat ... is there a workaround until your fix is live?

For iOS there is an issue, with media manager for the user Avatar while inviting. I haven't tested the Room chat, try creating Room chat instead of direct chat.

Velin92 commented 1 year ago

What is the issue? I have a couple of users who can't open a new chat ... is there a workaround until your fix is live?

try to disable rich text editor if you have it enabled. Since this issue seems to be linked to RTE

toshanmugaraj commented 1 year ago

This will crash Element-iOS anytime the user tries to use a mention in RTE's fullscreen mode.

I pushed a change in the upcoming update of the RTE that shifts over the media manager dependency from the room data source reference to the room main session.

This issue was due to the fact that with new DM, the room is not immediately created, hence room data source cannot be looked up. Fix is visible here: 8b43fcb

Yes, I was searching for the Avatar model usage, and was not able to find.