crash for audio call , updated protocol signature for jmcallkitlistener

element-hq / element-ios

A glossy Matrix collaboration client for iOS

https://element.io

Apache License 2.0

1.73k stars 486 forks source link

crash for audio call , updated protocol signature for jmcallkitlistener #7584

Closed toshanmugaraj closed 1 year ago

toshanmugaraj commented 1 year ago

Pull Request Checklist

[ x] I read the contributing guide
[ x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
[x ] Accessibility has been taken into account.
[ x] Pull request is based on the develop branch
[ x] Pull request contains a changelog file in ./changelog.d
[ x] You've made a self review of your PR
[ x] Pull request includes screenshots or videos of UI changes
[ x] Pull request includes a sign off Siged-off-by: Shunmugaraj toshanmugaraj@gmail.com

Velin92 commented 1 year ago

I see that this code is only changing the signature of the parameters, how is this going to fix a possible crash?

toshanmugaraj commented 1 year ago

I see that this code is only changing the signature of the parameters, how is this going to fix a possible crash?

Crash happens because the protocol is not implemented with the same signature. Its called from Objective C library, so it match the signature of the parameters.

The exact reason for the crash is unknown method called "providerDidActivateAudioSessionWithSession"

alexander-potemkin commented 1 year ago

I see that this code is only changing the signature of the parameters, how is this going to fix a possible crash?

Crash happens because the protocol is not implemented with the same signature. Its called from Objective C library, so it match the signature of the parameters.

The exact reason for the crash is unknown method called "providerDidActivateAudioSessionWithSession"

Thank you, @toshanmugaraj! It's not the first time you are fixing the bugs I encounter, really much appreciated!