element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

Implement MSC3987: Push actions clean-up #7585

Closed nimau closed 1 year ago

nimau commented 1 year ago

This PR implements the change requested by #7576 by adding support for MSC3987 which deprecates the dont_notify action for a push_rule.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (3e30eaf) 12.36% compared to head (12159cc) 12.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7585 +/- ## =========================================== - Coverage 12.36% 12.21% -0.15% =========================================== Files 1648 1648 Lines 163634 163663 +29 Branches 67192 67195 +3 =========================================== - Hits 20232 19992 -240 - Misses 142737 143026 +289 + Partials 665 645 -20 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.05% <ø> (ø)` | | | unittests | `6.06% <0.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [Riot/Categories/MXRoom+Riot.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9DYXRlZ29yaWVzL01YUm9vbStSaW90Lm0=) | `0.00% <0.00%> (ø)` | | | [.../MatrixSDK/MXRoomNotificationSettingsService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Sb29tL05vdGlmaWNhdGlvblNldHRpbmdzL1NlcnZpY2UvTWF0cml4U0RLL01YUm9vbU5vdGlmaWNhdGlvblNldHRpbmdzU2VydmljZS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...tions/Model/MatrixSDK/MXNotificationPushRule.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9TZXR0aW5ncy9Ob3RpZmljYXRpb25zL01vZGVsL01hdHJpeFNESy9NWE5vdGlmaWNhdGlvblB1c2hSdWxlLnN3aWZ0) | `0.00% <0.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7585/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.