element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

Fix: Prevents UserAvatarView from disappearing due to incorrect width. #7587

Closed nimau closed 1 year ago

nimau commented 1 year ago

This PR fixes an issue where the user's avatar can disappear from the top left menu of AllChatsViewController because the width of the AvatarView has become 0.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15 :warning:

Comparison is base (b10b75c) 12.36% compared to head (9997a16) 12.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7587 +/- ## =========================================== - Coverage 12.36% 12.21% -0.15% =========================================== Files 1648 1648 Lines 163663 163667 +4 Branches 67211 67194 -17 =========================================== - Hits 20238 19999 -239 - Misses 142760 143023 +263 + Partials 665 645 -20 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `6.06% <100.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...ot/Modules/Home/AllChats/AllChatsCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0hvbWUvQWxsQ2hhdHMvQWxsQ2hhdHNDb29yZGluYXRvci5zd2lmdA==) | `26.29% <100.00%> (+0.51%)` | :arrow_up: | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7587/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.