element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

Let user know about non accessible replies because of denied history access #7588

Closed giomfo closed 1 year ago

giomfo commented 1 year ago

Steps to reproduce

Scenario:

image

Outcome

What did you expect?

The original text should be hidden in UserB side

The client must check if the user has the permission to have access to the original event. For that, the client should check the response to the following request GET https://\<homeserver>/_matrix/client/r0/rooms/\<roomId>/context/\<eventId> If the answer is "403 Forbidden" -> the fallback has to be ignored The _replyto event rendering should be similar to Element-web rendering:

image

Suggested wording: "Unable to load event that was replied to, it either does not exist or you do not have permission to view it."

What happened instead?

User B sees the original message in the reply part of the message from User A

image

Here: "msg3" should not be visible by Marcel

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

giomfo commented 1 year ago

After investigation, we realized that it would be complex to fix this issue without rewriting all the reply_to logic. We know the issue will not appear in ElementX because the reply_to have been implemented without considering the fallback (like the Element web client is doing currently) We decided to close it as no planned for Element-iOS