Closed 0d1tt0 closed 1 year ago
I just found the reproducer for this:
On a newly created account the bug is not present. To reproduce follow these steps:
From the public room:
I figured out a work-around for red text. Tap-hold the channel, go to notifications and select none. Setting to All Messages (default) or Mentions and Keywords Only will just highlight everything in red on iOS.
From the public room:
I figured out a work-around for red text. Tap-hold the channel, go to notifications and select none. Setting to All Messages (default) or Mentions and Keywords Only will just highlight everything in red on iOS.
Ok but that isn’t so much a fix for this unless the intent is to say, “surprise! unless you don’t ever want to get notified, red is the new colour” unless of course the user settings supersede? Not being sarcastic, legit wondering.
Long shot but could this possibly relate to the deprecation of the dont_notify
action? The client-side changes for this are in 1.10.13 only (https://github.com/vector-im/element-ios/commit/b7d008d332ece0f315cd5ffb1330b8f364e5087a & https://github.com/vector-im/element-ios/commit/12159ccfe8bd8a1a4cc3f0fcd8a9df5c0c4319dc).
From the public room:
I figured out a work-around for red text. Tap-hold the channel, go to notifications and select none. Setting to All Messages (default) or Mentions and Keywords Only will just highlight everything in red on iOS.
Ok but that isn’t so much a fix for this unless the intent is to say, “surprise! unless you don’t ever want to get notified, red is the new colour” unless of course the user settings supersede? Not being sarcastic, legit wondering.
I'm just adding information to the issue that will be useful for debugging. It definitely wasn't a suggestion to do that :)
It's probably due to the new .m.is_room_mention
rule, there is no condition checker for the kind event_property_is
in MXNotificationCenter
.
Here is the log:
Element[96168:878235] [MXNotificationCenter] Warning: There is no MXPushRuleConditionChecker to check condition of kind: event_property_is
This issue is caused by Synapse version 1.86! Do anyone know where to find the dpkg of Synapse 1.85.2 to downgrade?
Long shot but could this possibly relate to the deprecation of the
dont_notify
action? The client-side changes for this are in 1.10.13 only (b7d008d & 12159cc).
@Johennes 1.10.13 has the same issue! It's related to Synapse 1.86 - that release broke it. 1.10.13 was fine with 1.85.2 and broke with 1.86. I'm now looking for the DEB package of Synapse 1.85.2 to downgrade until they fixed it. Any idea where I can download it? It's not in the Github assets.
Yes, my hunch turned out to be a red herring, sorry. Can you re-raise the question about the previous DEB package on the Synapse issue? I'm not familiar with how to downgrade it, sadly.
@0d1tt0 I propose to change the issue subject to "All message texts are red with Synapse 1.86". It's not only group messages, it's all chats ... also DM chats. Everything is freakin' red.
@Velin92 Maybe raise the priority to Major? After 1.86 was released yesterday this will get huge now ...
Possible client-side fix in https://github.com/matrix-org/matrix-ios-sdk/pull/1799
For all who want to downgrade to 1.85.2 on Ubuntu/Debian: DEB packages are here: https://github.com/matrix-org/synapse/releases/download/v1.85.2/debs.tar.xz
Installing the right flavor with dpkg -i
works for me, after deleting the cache in Element-IOS all is fine again.
Don't forget to apt-mark hold mytrix-synapse-py3
until this is officially fixed and released (on which side ever) if you don't want to have your users complaining.
It's merged, awesome!
@Johennes Will it find its way in 1.10.13 as it's not yet released in the store, or do "normal users" need to wait some weeks for 1.10.14?
We're preparing a hotfix in-between these two. Work on this is starting today so it should be shipped timely.
Steps to reproduce
Outcome
What did you expect?
The text is white
What happened instead?
The text is red
Your phone model
iPhone 14 Pro
Operating system version
16.5 (20F66)
Application version
1.10.12
Homeserver
matrix.org
Will you send logs?
Yes