element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

Disable Siri, Share and Reply (from NSE) Extensions. #7619

Closed pixlwave closed 1 year ago

pixlwave commented 1 year ago

This PR disables the targets, but the code remains. And we no longer use QUICK_REPLY as a category on notifications.

Closes #7618.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (9c8a8cf) 12.36% compared to head (b7e7c78) 12.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7619 +/- ## =========================================== - Coverage 12.36% 12.21% -0.15% =========================================== Files 1648 1648 Lines 163667 163667 Branches 67211 67195 -16 =========================================== - Hits 20239 19996 -243 - Misses 142763 143026 +263 + Partials 665 645 -20 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `6.06% <ø> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. [see 14 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7619/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

antdude commented 1 year ago

This is disappointing after I updated my iOS app today. I can no longer share from other iOS apps in my iPhone (iOS v16.6). I guess I will have to use other Matrix apps like FluffyChat. :(