element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Fix a crash when opening v11 rooms. #7635

Closed pixlwave closed 11 months ago

pixlwave commented 11 months ago

creator was removed in v11 instead favouring sender. This field is currently defined in the spec as required, hence the crash. https://github.com/matrix-org/matrix-spec-proposals/pull/2175

Probably best to hide whitespaces on that diff.

Fixes #7633

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.14% :tada:

Comparison is base (04c7a02) 12.21% compared to head (8085526) 12.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7635 +/- ## =========================================== + Coverage 12.21% 12.36% +0.14% =========================================== Files 1648 1648 Lines 163667 163665 -2 Branches 67195 67209 +14 =========================================== + Hits 19996 20236 +240 + Misses 143026 142764 -262 - Partials 645 665 +20 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.05% <ø> (ø)` | | | unittests | `6.21% <0.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL01hdHJpeEtpdC9VdGlscy9FdmVudEZvcm1hdHRlci9NWEtFdmVudEZvcm1hdHRlci5t) | `16.93% <0.00%> (-0.01%)` | :arrow_down: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.