search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Fix SSO generating invalid URLs. #7639

Closed pixlwave closed 11 months ago

pixlwave commented 11 months ago

When signing into to element.io the generated URL was login/sso/redirect/?redirectUrl=… but should be login/sso/redirect?redirectUrl=… without the trailing slash.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d3e64c1) 12.21% compared to head (3193da2) 12.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7639 +/- ## ======================================== Coverage 12.21% 12.21% ======================================== Files 1648 1648 Lines 163668 163667 -1 Branches 67195 67194 -1 ======================================== Hits 19996 19996 + Misses 143027 143026 -1 Partials 645 645 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.05% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [.../Authentication/SSO/SSOAuthenticationService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL1NTTy9TU09BdXRoZW50aWNhdGlvblNlcnZpY2Uuc3dpZnQ=) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.