element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Only use the sender when rendering the room creation event. #7640

Closed pixlwave closed 1 year ago

pixlwave commented 1 year ago

On Room v11 it is possible that the sender could put in a fake creator. Don't allow this to happen.

The changelog already exists for this as #7633

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.14% :tada:

Comparison is base (d3e64c1) 12.21% compared to head (a68c6f0) 12.36%. Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7640 +/- ## =========================================== + Coverage 12.21% 12.36% +0.14% =========================================== Files 1648 1648 Lines 163668 163660 -8 Branches 67195 67206 +11 =========================================== + Hits 19996 20236 +240 + Misses 143027 142759 -268 - Partials 645 665 +20 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `55.05% <ø> (ø)` | | | unittests | `6.21% <0.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL01hdHJpeEtpdC9VdGlscy9FdmVudEZvcm1hdHRlci9NWEtFdmVudEZvcm1hdHRlci5t) | `16.97% <0.00%> (+0.04%)` | :arrow_up: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.