search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

hide account deactivation in OIDC #7652

Closed Velin92 closed 1 year ago

Velin92 commented 1 year ago

fixes #7648

This PR also includes a way to make the app remember that the last SSO login was using OIDC. This will only work from the next new hard login.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (b7ffeda) 12.37% compared to head (049eb8c) 12.37%. Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7652 +/- ## ======================================== Coverage 12.37% 12.37% ======================================== Files 1648 1648 Lines 163614 163632 +18 Branches 67171 67179 +8 ======================================== + Hits 20242 20251 +9 - Misses 142707 142716 +9 Partials 665 665 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7652/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `55.04% <100.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.22% <80.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [Riot/Modules/Application/LegacyAppDelegate.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0FwcGxpY2F0aW9uL0xlZ2FjeUFwcERlbGVnYXRlLm0=) | `15.60% <0.00%> (-0.01%)` | :arrow_down: | | [...les/Authentication/AuthenticationCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uQ29vcmRpbmF0b3Iuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [Riot/Modules/Settings/SettingsViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1NldHRpbmdzL1NldHRpbmdzVmlld0NvbnRyb2xsZXIubQ==) | `0.00% <0.00%> (ø)` | | | [.../Legacy/SocialLogin/SocialLoginButtonFactory.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL0xlZ2FjeS9Tb2NpYWxMb2dpbi9Tb2NpYWxMb2dpbkJ1dHRvbkZhY3Rvcnkuc3dpZnQ=) | `80.17% <66.66%> (ø)` | | | [...ation/Legacy/SocialLogin/SocialLoginListView.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL0xlZ2FjeS9Tb2NpYWxMb2dpbi9Tb2NpYWxMb2dpbkxpc3RWaWV3LnN3aWZ0) | `77.77% <66.66%> (ø)` | | | [Riot/Managers/Settings/RiotSettings.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9NYW5hZ2Vycy9TZXR0aW5ncy9SaW90U2V0dGluZ3Muc3dpZnQ=) | `88.61% <100.00%> (+0.09%)` | :arrow_up: | | [...thentication/Legacy/AuthenticationViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL0xlZ2FjeS9BdXRoZW50aWNhdGlvblZpZXdDb250cm9sbGVyLm0=) | `35.74% <100.00%> (ø)` | | | [...s/Authentication/Common/AuthenticationModels.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9BdXRoZW50aWNhdGlvbi9Db21tb24vQXV0aGVudGljYXRpb25Nb2RlbHMuc3dpZnQ=) | `52.38% <100.00%> (+1.16%)` | :arrow_up: | | [...mmon/Service/MatrixSDK/AuthenticationService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9BdXRoZW50aWNhdGlvbi9Db21tb24vU2VydmljZS9NYXRyaXhTREsvQXV0aGVudGljYXRpb25TZXJ2aWNlLnN3aWZ0) | `71.14% <100.00%> (+1.51%)` | :arrow_up: | | [...ication/Common/Service/MatrixSDK/LoginModels.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9BdXRoZW50aWNhdGlvbi9Db21tb24vU2VydmljZS9NYXRyaXhTREsvTG9naW5Nb2RlbHMuc3dpZnQ=) | `65.90% <100.00%> (+0.69%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7652/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.