element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Hide deactivate account if the auth property is present on the WK. #7654

Closed Velin92 closed 11 months ago

Velin92 commented 11 months ago

fixes #7648

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

Velin92 commented 11 months ago

Easy when you know how 🙃

I think there's a missing SDK PR to go alongside this, but certainly looks good in the app.

https://github.com/matrix-org/matrix-ios-sdk/pull/1812 Already merged!

codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (83e7229) 12.22% compared to head (76c2687) 12.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7654 +/- ## ======================================== Coverage 12.22% 12.22% ======================================== Files 1648 1648 Lines 163619 163619 Branches 67155 67155 ======================================== Hits 19997 19997 Misses 142976 142976 Partials 646 646 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7654/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7654/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.07% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [Riot/Modules/Settings/SettingsViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1NldHRpbmdzL1NldHRpbmdzVmlld0NvbnRyb2xsZXIubQ==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.