search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Sign out through MAS redirect confirmation alerts #7658

Closed Velin92 closed 1 year ago

Velin92 commented 1 year ago

fixes #7646

https://github.com/vector-im/element-ios/assets/34335419/d4fc0314-5599-422a-a804-020bdbb60495

https://github.com/vector-im/element-ios/assets/34335419/0ba8cd60-20bb-450f-bf65-89a17a27959e

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.14% :tada:

Comparison is base (f7a3a80) 12.21% compared to head (15bb73f) 12.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7658 +/- ## =========================================== + Coverage 12.21% 12.36% +0.14% =========================================== Files 1648 1648 Lines 163675 163723 +48 Branches 67183 67222 +39 =========================================== + Hits 19995 20240 +245 + Misses 143033 142817 -216 - Partials 647 666 +19 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7658/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7658/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.21% <0.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7658?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...curity/ManageSession/ManageSessionViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7658?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1NldHRpbmdzL1NlY3VyaXR5L01hbmFnZVNlc3Npb24vTWFuYWdlU2Vzc2lvblZpZXdDb250cm9sbGVyLm0=) | `0.00% <0.00%> (ø)` | | | [...ions/Coordinator/UserSessionsFlowCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7658?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvQ29vcmRpbmF0b3IvVXNlclNlc3Npb25zRmxvd0Nvb3JkaW5hdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7658/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.