element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Fix event forwarding #7663

Closed nimau closed 1 year ago

nimau commented 1 year ago

This PR fixes #7641 There were two issues:

The fix is in two parts:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (98feb0c) 11.85% compared to head (8fef029) 11.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7663 +/- ## ======================================== Coverage 11.85% 11.85% ======================================== Files 1648 1648 Lines 163723 163700 -23 Branches 67177 67167 -10 ======================================== Hits 19412 19412 + Misses 143673 143650 -23 Partials 638 638 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7663/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `55.04% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [Riot/Modules/Room/RoomViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1Jvb20vUm9vbVZpZXdDb250cm9sbGVyLm0=) | `0.00% <ø> (ø)` | | | [...reExtension/Shared/ForwardingShareItemSender.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFNoYXJlRXh0ZW5zaW9uL1NoYXJlZC9Gb3J3YXJkaW5nU2hhcmVJdGVtU2VuZGVyLnN3aWZ0) | `0.00% <ø> (ø)` | | | [RiotShareExtension/Shared/ShareManager.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFNoYXJlRXh0ZW5zaW9uL1NoYXJlZC9TaGFyZU1hbmFnZXIubQ==) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.