element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Use ASWebAuthenticationSession to display OIDC account management URL #7671

Closed hughns closed 10 months ago

hughns commented 10 months ago

Fixes #7668

Pull Request Checklist

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.36% :tada:

Comparison is base (5cbd1df) 11.85% compared to head (a31327b) 12.22%. Report is 11 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7671 +/- ## =========================================== + Coverage 11.85% 12.22% +0.36% =========================================== Files 1648 1650 +2 Lines 163748 163832 +84 Branches 67186 67241 +55 =========================================== + Hits 19412 20021 +609 + Misses 143698 143165 -533 - Partials 638 646 +8 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7671/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7671/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `54.96% <ø> (-0.09%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7671/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.07% <0.00%> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...Modules/Authentication/SSO/SSOAccountService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL1NTTy9TU09BY2NvdW50U2VydmljZS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...uthentication/SSO/SSOAuthenticationPresenter.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL1NTTy9TU09BdXRoZW50aWNhdGlvblByZXNlbnRlci5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [.../Authentication/SSO/SSOAuthenticationService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL0F1dGhlbnRpY2F0aW9uL1NTTy9TU09BdXRoZW50aWNhdGlvblNlcnZpY2Uuc3dpZnQ=) | `0.00% <ø> (ø)` | | | [...curity/ManageSession/ManageSessionViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1NldHRpbmdzL1NlY3VyaXR5L01hbmFnZVNlc3Npb24vTWFuYWdlU2Vzc2lvblZpZXdDb250cm9sbGVyLm0=) | `0.00% <0.00%> (ø)` | | | [Riot/Modules/Settings/SettingsViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1NldHRpbmdzL1NldHRpbmdzVmlld0NvbnRyb2xsZXIubQ==) | `0.00% <0.00%> (ø)` | | | [...ions/Coordinator/UserSessionsFlowCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvQ29vcmRpbmF0b3IvVXNlclNlc3Npb25zRmxvd0Nvb3JkaW5hdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7671/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

pixlwave commented 10 months ago

@hughns I added an extra commit that uses the existing SSOAuthenticationPresenter so we have consistency between auth and account on iOS 14 too. (iOS 14 uses a SFSafariViewController during login due to a bug with guided access).