search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Hide all Sign Out X/All Sessions buttons in the Device Manager when using OIDC. #7674

Closed pixlwave closed 10 months ago

pixlwave commented 10 months ago

Fixes #7672 by hiding the mentioned buttons when the homeserver is using OIDC.

Current Session Other Section Other Screen
Simulator Screenshot - iPhone 14 - 2023-09-12 at 11 32 04 Simulator Screenshot - iPhone 14 - 2023-09-12 at 11 31 51 Simulator Screenshot - iPhone 14 - 2023-09-12 at 11 32 30
sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 78.94% and no project coverage change.

Comparison is base (d2773b3) 12.22% compared to head (81c93ae) 12.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7674 +/- ## ======================================== Coverage 12.22% 12.22% ======================================== Files 1649 1649 Lines 163777 163784 +7 Branches 67226 67224 -2 ======================================== + Hits 20021 20029 +8 + Misses 143110 143109 -1 Partials 646 646 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7674/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7674/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `54.97% <78.94%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...ions/Coordinator/UserSessionsFlowCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvQ29vcmRpbmF0b3IvVXNlclNlc3Npb25zRmxvd0Nvb3JkaW5hdG9yLnN3aWZ0) | `0.00% <ø> (ø)` | | | [...ons/Coordinator/UserOtherSessionsCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnMvQ29vcmRpbmF0b3IvVXNlck90aGVyU2Vzc2lvbnNDb29yZGluYXRvci5zd2lmdA==) | `0.00% <ø> (ø)` | | | [.../Coordinator/UserSessionsOverviewCoordinator.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlclNlc3Npb25zT3ZlcnZpZXcvQ29vcmRpbmF0b3IvVXNlclNlc3Npb25zT3ZlcnZpZXdDb29yZGluYXRvci5zd2lmdA==) | `0.00% <ø> (ø)` | | | [...rSessionsOverview/UserSessionsOverviewModels.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlclNlc3Npb25zT3ZlcnZpZXcvVXNlclNlc3Npb25zT3ZlcnZpZXdNb2RlbHMuc3dpZnQ=) | `100.00% <ø> (ø)` | | | [...erSessionsOverview/View/UserSessionsOverview.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlclNlc3Npb25zT3ZlcnZpZXcvVmlldy9Vc2VyU2Vzc2lvbnNPdmVydmlldy5zd2lmdA==) | `77.66% <42.85%> (-0.29%)` | :arrow_down: | | [...herSessions/MockUserOtherSessionsScreenState.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnMvTW9ja1VzZXJPdGhlclNlc3Npb25zU2NyZWVuU3RhdGUuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [...UserOtherSessions/UserOtherSessionsViewModel.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnNWaWV3TW9kZWwuc3dpZnQ=) | `82.63% <100.00%> (+0.12%)` | :arrow_up: | | [...ons/UserOtherSessions/View/UserOtherSessions.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnMvVmlldy9Vc2VyT3RoZXJTZXNzaW9ucy5zd2lmdA==) | `84.76% <100.00%> (+0.14%)` | :arrow_up: | | [...rOtherSessions/View/UserOtherSessionsToolbar.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlck90aGVyU2Vzc2lvbnMvVmlldy9Vc2VyT3RoZXJTZXNzaW9uc1Rvb2xiYXIuc3dpZnQ=) | `89.74% <100.00%> (ø)` | | | [...Overview/MockUserSessionsOverviewScreenState.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9Vc2VyU2Vzc2lvbnMvVXNlclNlc3Npb25zT3ZlcnZpZXcvTW9ja1VzZXJTZXNzaW9uc092ZXJ2aWV3U2NyZWVuU3RhdGUuc3dpZnQ=) | `93.33% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/vector-im/element-ios/pull/7674?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.