element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Allow the use Jitsi for 1:1 calls with a well-known configuration flag. #7685

Closed pixlwave closed 9 months ago

pixlwave commented 9 months ago

This PR allows the use of Jitsi for 1:1 calls when the client well-known contains the following:

"io.element.jitsi": {
    "useFor1To1Calls": true
}

It additionally bumps cocoapods to v1.13.0.

Closes #7684 Similar PR in the SDK for Cocoapods: https://github.com/matrix-org/matrix-ios-sdk/pull/1820

https://github.com/vector-im/element-ios/assets/6060466/9611a237-e952-4f1e-83ed-621b74d343bb

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

github-actions[bot] commented 9 months ago

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YXkzSz

codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dba35a5) 12.35% compared to head (86d6e23) 12.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7685 +/- ## =========================================== + Coverage 12.35% 12.37% +0.01% =========================================== Files 1650 1650 Lines 163846 163854 +8 Branches 67253 67258 +5 =========================================== + Hits 20250 20274 +24 + Misses 142931 142912 -19 - Partials 665 668 +3 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7685/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7685/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `54.97% <ø> (-0.06%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7685/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.22% <50.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [...Configuration/HomeserverConfigurationBuilder.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2RlbC9Ib21lc2VydmVyQ29uZmlndXJhdGlvbi9Ib21lc2VydmVyQ29uZmlndXJhdGlvbkJ1aWxkZXIuc3dpZnQ=) | `88.88% <100.00%> (+0.29%)` | :arrow_up: | | [...erConfiguration/HomeserverJitsiConfiguration.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2RlbC9Ib21lc2VydmVyQ29uZmlndXJhdGlvbi9Ib21lc2VydmVySml0c2lDb25maWd1cmF0aW9uLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Riot/Model/WellKnown/VectorWellKnown.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2RlbC9XZWxsS25vd24vVmVjdG9yV2VsbEtub3duLnN3aWZ0) | `100.00% <ø> (ø)` | | | [Riot/Modules/Room/RoomViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1Jvb20vUm9vbVZpZXdDb250cm9sbGVyLm0=) | `0.00% <0.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7685/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.