search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Fix new dm crash with RTE is enabled #7692

Closed alfogrillo closed 1 year ago

alfogrillo commented 1 year ago

Fix https://github.com/vector-im/element-ios/issues/7689

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

codecov[bot] commented 1 year ago

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (f1b6f52) 11.85% compared to head (df21fa7) 12.37%. Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7692 +/- ## =========================================== + Coverage 11.85% 12.37% +0.51% =========================================== Files 1650 1650 Lines 163857 163866 +9 Branches 67216 67265 +49 =========================================== + Hits 19429 20277 +848 + Misses 143791 142921 -870 - Partials 637 668 +31 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7692/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `54.97% <ø> (-0.06%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.22% <0.00%> (+0.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/vector-im/element-ios/pull/7692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [Riot/Modules/Room/RoomViewController.m](https://app.codecov.io/gh/vector-im/element-ios/pull/7692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdC9Nb2R1bGVzL1Jvb20vUm9vbVZpZXdDb250cm9sbGVyLm0=) | `0.00% <0.00%> (ø)` | | | [...ogin/Common/Service/MatrixSDK/QRLoginService.swift](https://app.codecov.io/gh/vector-im/element-ios/pull/7692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#diff-UmlvdFN3aWZ0VUkvTW9kdWxlcy9BdXRoZW50aWNhdGlvbi9RUkxvZ2luL0NvbW1vbi9TZXJ2aWNlL01hdHJpeFNESy9RUkxvZ2luU2VydmljZS5zd2lmdA==) | `6.92% <0.00%> (-0.18%)` | :arrow_down: | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/vector-im/element-ios/pull/7692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.