element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 479 forks source link

Localizable strings aren't reorderable #7700

Open TellowKrinkle opened 9 months ago

TellowKrinkle commented 9 months ago

Steps to reproduce

  1. Get in a situation where these strings are displayed: https://github.com/vector-im/element-ios/blob/94dc313aa880120be96fb2fe9dd11eb6fb7a84e9/Riot/Assets/en.lproj/Vector.strings#L1188-L1189
  2. Change your language to Japanese
  3. View the strings

Outcome

What did you expect?

To see あなたの他のセッションに暗号鍵を再要求

What happened instead?

I get 暗号鍵を再要求 あなたの他のセッションに。

I'm seeing a lot of part1/part2 strings in that strings file, and I'd guess they all need to be reformatted in a way that lets translators reorder them.

Your phone model

iPhone XS

Operating system version

iOS 16.6.1

Application version

Element 1.11.4

Homeserver

matrix.org

Will you send logs?

Yes