search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Bump RTE version to 2.18.0 #7711

Closed nimau closed 10 months ago

nimau commented 10 months ago

This PR updates the version of RTE used in Element iOS. This fixes:

Changes:

github-actions[bot] commented 10 months ago

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qac2qv

codecov[bot] commented 10 months ago

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (5a0a0f9) 6.22% compared to head (a259e91) 12.38%.

Files Patch % Lines
Riot/Modules/Room/RoomViewController.swift 0.00% 18 Missing :warning:
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% 17 Missing :warning:
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 81.66% 10 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7711 +/- ## =========================================== + Coverage 6.22% 12.38% +6.16% =========================================== Files 1648 1650 +2 Lines 163846 163929 +83 Branches 66296 66414 +118 =========================================== + Hits 10200 20306 +10106 + Misses 153203 142955 -10248 - Partials 443 668 +225 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7711/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `55.02% <81.96%> (?)` | | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `6.22% <3.03%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Velin92 commented 10 months ago

Let's bump this up to 2.18.0 so that we can also fix the nasty https://github.com/vector-im/element-ios/issues/7489 bug

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here