element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Update cross-signing status ui after activation in settings #7714

Open NicolasBuquet opened 10 months ago

NicolasBuquet commented 10 months ago

When activating cross-signing in Security settings, either directly or by activating Secure Backup, the cross-signing status is not updated in UI.

If you leave Security Settings and open it back right away, the cross-signing status is updated.

Update it right after activation without having to leave the screen.

Pull Request Checklist

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d50b82a) 12.37% compared to head (be4fbc3) 12.03%. Report is 25 commits behind head on develop.

Files Patch % Lines
...Modules/Settings/Security/SecurityViewController.m 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7714 +/- ## =========================================== - Coverage 12.37% 12.03% -0.34% =========================================== Files 1650 1650 Lines 163869 163920 +51 Branches 67267 67277 +10 =========================================== - Hits 20277 19727 -550 - Misses 142927 143533 +606 + Partials 665 660 -5 ``` | [Flag](https://app.codecov.io/gh/vector-im/element-ios/pull/7714/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/vector-im/element-ios/pull/7714/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `55.03% <ø> (+0.06%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/vector-im/element-ios/pull/7714/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im) | `5.86% <0.00%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vector-im#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CLAassistant commented 1 week ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nicolas Buquet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.