element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 480 forks source link

Fix dictation when using the Rich Text Editor. #7752

Closed pixlwave closed 4 months ago

pixlwave commented 4 months ago

Upgrades to the latest version of the RTE package, and adjusts the key commands to fix build errors.

https://github.com/element-hq/element-ios/assets/6060466/810ca870-3bbd-4e33-9444-cc27dd025389

codecov[bot] commented 4 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2a6677c) 12.38% compared to head (02f1bac) 12.23%.

Files Patch % Lines
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 62.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7752 +/- ## =========================================== - Coverage 12.38% 12.23% -0.16% =========================================== Files 1650 1650 Lines 163918 163916 -2 Branches 66408 66388 -20 =========================================== - Hits 20309 20054 -255 - Misses 142941 143215 +274 + Partials 668 647 -21 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-ios/pull/7752/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/element-hq/element-ios/pull/7752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `55.05% <62.50%> (+0.03%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/element-hq/element-ios/pull/7752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `6.06% <0.00%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.