element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 480 forks source link

Disable mark as unread #7758

Closed stefanceriu closed 4 months ago

stefanceriu commented 4 months ago

As part of element-hq/element-meta/issues/2197 and the new version of mark as unread (based on MSC2876) it has been decided that the old (local only, iOS only) legacy implementation be disabled to avoid confusion.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1dc609b) 12.38% compared to head (c8c6f55) 12.24%.

Files Patch % Lines
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% 1 Missing :warning:
...ntextMenu/ActionProviders/RoomActionProvider.swift 0.00% 1 Missing :warning:
...ontextMenu/Services/RoomContextActionService.swift 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7758 +/- ## =========================================== - Coverage 12.38% 12.24% -0.15% =========================================== Files 1650 1650 Lines 163913 163910 -3 Branches 66402 66386 -16 =========================================== - Hits 20305 20071 -234 - Misses 142940 143191 +251 + Partials 668 648 -20 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-ios/pull/7758/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/element-hq/element-ios/pull/7758/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `55.05% <ø> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/element-hq/element-ios/pull/7758/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `6.07% <0.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.