element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Analytics | permanent vs temporary utd #7770

Closed BillCarsonFr closed 6 months ago

BillCarsonFr commented 6 months ago

Preliminary work for https://github.com/element-hq/element-ios/issues/7767

depends on https://github.com/element-hq/element-ios/pull/7769

Add support for permanent vs temporary UTD. If an event is decrypted in less than 4s after decryption, it should be graced. If it's decrypted in > 4s and less than 60s, we still report as an UTD but with the time to decrypt. If after 60s it's not decrypted report as permanent UTD

Pull Request Checklist

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 12.45%. Comparing base (95fd61f) to head (1d633e8).

Files Patch % Lines
Riot/Modules/Analytics/Analytics.swift 0.00% 2 Missing :warning:
...t/Modules/Analytics/DecryptionFailureTracker.swift 95.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## valere/swiftify_decryption_tracker #7770 +/- ## ====================================================================== + Coverage 12.29% 12.45% +0.15% ====================================================================== Files 1650 1651 +1 Lines 163903 163946 +43 Branches 67293 67325 +32 ====================================================================== + Hits 20156 20416 +260 + Misses 143108 142880 -228 - Partials 639 650 +11 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-ios/pull/7770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-ios/pull/7770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `6.23% <93.93%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.