element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 480 forks source link

Telemetry | Add additional properties to posthog UTD errors #7776

Closed BillCarsonFr closed 2 months ago

BillCarsonFr commented 2 months ago

Pull Request Checklist

Based on https://github.com/element-hq/element-ios/pull/7775

Last step of https://github.com/element-hq/element-ios/issues/7767

Add the new properties isMatrixOrg, isFederated and wasVisibleToUser.

Note: wasVisibleToUser is always true for now, as the UTD are reported only from the EventFormatter. Additional work is needed to report visible vs not visible. This would require to move down the DecryptionFailureTracker into the SDK

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 12.27%. Comparing base (d0890d5) to head (a5d4d1c). Report is 2 commits behind head on develop.

:exclamation: Current head a5d4d1c differs from pull request most recent head afd6dee. Consider uploading reports for the commit afd6dee to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7776 +/- ## =========================================== + Coverage 12.25% 12.27% +0.01% =========================================== Files 1651 1651 Lines 164133 164167 +34 Branches 67490 67499 +9 =========================================== + Hits 20116 20148 +32 Misses 143346 143346 - Partials 671 673 +2 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-ios/pull/7776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-ios/pull/7776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `6.13% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud