Olm sessions broken by use of outdated cache

element-hq / element-ios

A glossy Matrix collaboration client for iOS

https://element.io

GNU Affero General Public License v3.0

1.73k stars 500 forks source link

Olm sessions broken by use of outdated cache #7790

Open richvdh opened 6 months ago

richvdh commented 6 months ago

We recently found and fixed a bug in Element X iOS (https://github.com/matrix-org/matrix-rust-sdk/issues/3110) which caused Olm sessions to be corrupted due to lack of cache invalidation when control switched between the main process and the NSE process.

According to @BillCarsonFr, Element iOS suffers the same problem; we should fix this as it causes users on other platforms to see UTD errors.

richvdh commented 6 months ago

Estimated as "S" assuming we just delete the crypto store cache when we come to the foreground

BillCarsonFr commented 6 months ago

In RC https://github.com/element-hq/element-ios/pull/7798

richvdh commented 4 months ago

According to @BillCarsonFr, this is still a potential problem.

The current workaround on classic ios is that we "refresh" the olm machine when the app enters foreground So the workaround limits the possibilities of outdated cache but not 100% of them

richvdh commented 4 months ago