element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.72k stars 480 forks source link

Bump posthog version to 3.25 #7793

Closed BillCarsonFr closed 1 month ago

BillCarsonFr commented 1 month ago

Fixes https://github.com/element-hq/crypto-internal/issues/314

Updated posthog library to 3.2.5 in order to benefit from per session grouping. I had to move out Posthog from cocoapod and use swiftPM instead, was getting an error on posthog via cocoapod see here

There are some changes with the new Posthog SDK, main one is around setting userProperties that has dedicated API now (no need to manually put the $set), updated the test.

There are some things I am not sure should be commited, like the Package.resolved change on swift-collections or the COCOAPODS version change in the lock file. Let me know how to handle that.

Pull Request Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 12.33%. Comparing base (1ccf0b6) to head (cf3dcca). Report is 15 commits behind head on develop.

:exclamation: Current head cf3dcca differs from pull request most recent head e1b9bbb

Please upload reports for the commit e1b9bbb to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #7793 +/- ## =========================================== + Coverage 12.27% 12.33% +0.06% =========================================== Files 1651 1651 Lines 164171 163960 -211 Branches 67502 67314 -188 =========================================== + Hits 20148 20232 +84 + Misses 143350 143091 -259 + Partials 673 637 -36 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-ios/pull/7793/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/element-hq/element-ios/pull/7793/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `55.65% <ø> (+0.63%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud