search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 498 forks source link

No sound / call on group calls #7858

Open alexander-potemkin opened 3 weeks ago

alexander-potemkin commented 3 weeks ago

Steps to reproduce

  1. Where are you starting? What can you see?

Enable iOS groups calls notification in Lab settings, start a group call - only silent notification would appear, like for the message, but even without a sound.

  1. What do you click?

Enable setting in the lab and regular actions then.

Outcome

What did you expect?

A notification with sound at least. Ideally - a full scale call, like in 1:1 messages.

What happened instead?

Kind of nothing :) Only a silent notification that disappears and so easy to miss.

Your phone model

Any

Operating system version

Any

Application version

Any

Homeserver

Any

Will you send logs?

Yes

alexander-potemkin commented 3 weeks ago

@manuroe , @ismailgulek , @pixlwave , I know it's been quite some time, but it seems like you could be the right contacts - please, do correct me if I'm wrong!

I can see the commits mentioning integration with iOS's CallKit (commit) and notifications for group calls (commit) - so it feels like, with 'group calls' lab feature enabled, iOS shall ring a bell for the group calls, like for any other call (like WhatsApp for example; or even Element's 1:1 calls).

But now it doesn't - the only thing that happens, it's a notification temporary banner - like for the message, but not like for the messages, this banner appears without sound and is not persistent. And it's so easy to miss it as well!

Is it some bug introduced since the feature has been implemented? Or it's some additional development required? If so, would you be open to accept a PR if it implements a functionality required?

Thanks in advance!

alexander-potemkin commented 2 weeks ago

Read Matrix 2.0 announce and a mention on iOS 18 bug with WebRTC - the issue I'm reporting is on iOS 17.7, so I don't believe it's the root cause.

pixlwave commented 2 weeks ago

Hey @alexander-potemkin. I'm afraid to say that as this feature is under a Labs flag we're not going to be able to look at it as we're focused on Element X iOS now and basically only looking at Element iOS for high severity bugs.

alexander-potemkin commented 2 weeks ago

Hey @alexander-potemkin. I'm afraid to say that as this feature is under a Labs flag we're not going to be able to look at it as we're focused on Element X iOS now and basically only looking at Element iOS for high severity bugs.

Thank you for prompt and direct response! Understood. Just in case - does it mean you are unlikely to consider pull request as well?

pixlwave commented 2 weeks ago

Yes I'm afraid so, unless it ends up being a really small bug fix PR in which case we can probably take a look at it.

alexander-potemkin commented 2 weeks ago

Yes I'm afraid so, unless it ends up being a really small bug fix PR in which case we can probably take a look at it.

Sure, makes perfect sense! Let me see if I will manage to squeeze it into a small, easy to pick up PR :)