element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

video/webp stickers not working in Element #1174

Open sleroq opened 1 year ago

sleroq commented 1 year ago

I am currently developing a sticker picker widget and I noticed that video/webp stickers are not supported and do not load in the Element client. I am wondering if this is intended behavior, and if so, why not support video/webp format?

When attempting to use video/webp stickers in a chat, they do not load and appear as blank spaces. This is different from regular static stickers, which work properly in the Element.

Steps to reproduce

  1. Start a chat with someone
  2. Send video/webp sticker
  3. Sticker is not visible
  4. In some cases, clicking on the broken sticker on the android client may cause the app to hang.

Outcome

What did you expect?

video/webp stickers should load properly in the Element, just like regular static stickers.

What happened instead?

video/webp stickers do not load when attempted to be used in a chat.

Operating system

NixOS

Browser information

Firefox 110.0.1 (64-bit)

URL for webapp

https://app.element.io/

Application version

Element version: 1.11.25 Olm version: 3.2.12

Homeserver

any

Will you send logs?

No

Element web Screenshot
Clicked on sticker few times from android
Example event

``` { "type": "m.sticker", "sender": "@sleroq:virto.community", "content": { "url": "mxc://virto.community/TuEzzIboWxNNEtPsFWhbxwmb", "info": { "h": 400, "w": 512, "mimetype": "video/webp", "size": 93617 }, "body": "😨" }, "origin_server_ts": 1679328542820, "unsigned": { "age": 55332629, "transaction_id": "m1679328542053.1" }, "event_id": "$QfRVmvcrF7oz4nvoySpqwkgVGrip_1JnFXZd05qWKkE", "room_id": "!jKsbIXzqLxdqPByEFn:virto.community" } ```

Thank you for your attention to this matter.

t3chguy commented 1 year ago

@robintown why would this need design?

robintown commented 1 year ago

Potentially for details such as whether animated stickers get the 'GIF' labeling that other animated images do. Though I agree, this could be fixed without design guidance.

t3chguy commented 1 year ago

This looks to be due to stickers relying on server-side thumbnails and Synapse being unable to generate a thumb for videos

image

Moving to meta to consider whether want to support video/* stickers