search

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

Implement Intentional Mentions (MSC3952) on Mobile #1516

Open daniellekirkwood opened 1 year ago

daniellekirkwood commented 1 year ago

Your use case

MSC3952 is nearly out of FCP. Once completed we will need to implement and stabilise it.

For cross-linking (originally from https://github.com/vector-im/element-meta/issues/886#issuecomment-1570271887):

daniellekirkwood commented 1 year ago

@giomfo Created this 'holding' issue based on our conversation today (before I forget). I will add more to it tomorrow

clokep commented 1 year ago

@daniellekirkwood I filed matrix-org/synapse#15487 for the Synapse side.

daniellekirkwood commented 1 year ago

This doesn't need to be on the WAT board anymore -- @Johennes & @clokep did we get the Synapse and EleWeb side of this sorted? Should I move it to a mobile only issue and assign to the right folks?

Johennes commented 1 year ago

There is nothing left to do on the Element Web side AFAIK.

clokep commented 1 year ago

did we get the Synapse and EleWeb side of this sorted?

Synapse supports it, as does Element Web & its components. It would be nice to finish off support for Matrix 1.7 in Synapse so clients are able to easily see this is supported, but it is not a requirement since clients can see the push rule and key off that.

Should I move it to a mobile only issue and assign to the right folks?

For cross-linking (originally from https://github.com/vector-im/element-meta/issues/886#issuecomment-1570271887):

daniellekirkwood commented 1 year ago

@manuroe @giomfo @VolkerJunginger

We've done most of what we need on the server and web side here so I've updated the task to be an EX one. Let us know if you have questions, otherwise we'll leave this to prioritise on your roadmap. Thanks.

giomfo commented 1 year ago

@manuroe @langleyd FYI the intentional mentions (MSC3952) has been taken into account when we "Expose the push notification settings #1959" in Rust SDK. Some updates have been applied on this implementation to improve it like this PR. I consider EX is ready to support MSC3952 - You may double check with EX Feature team About Legacy Element mobile clients, nothing has been done, the mention handling would depend only on the legacy push rules. I think the new push rules are ignored by default on these clients.

manuroe commented 1 year ago

The platform team is on it, assembling the different pieces made by other teams. Thanks all!

I edited the issue with user stories that cover intentional mentions on EX mobile. They are part of the broader [Epic] Mentions that will make mentions work for real even in E2EE rooms!