search

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
73 stars 12 forks source link

Verifying devices steps with emojis is a bit approximate and not so reassuring #1896

Open eauchat opened 5 years ago

eauchat commented 5 years ago

Description

This question concerns the interaction between different clients (in the tested case: desktop and android app). I hope it hasn't been addressed somewhere, I didn't find such type of issue.

Following the steps of devices verification (between my laptop and phone), I got at the following screens, asking me to verify that the same emojis are displayed both in the desktop app and phone app.

This looked like this:

Those two screen give me the feeling that I can accept the verification, but looking in the details I find many small differences.

One observation:

I understand that the set of emojis is not the same in the desktop and on the phone, therefore they display differently, but I still feel it would be nicer to use exactly the same images in all devices, so it really looks the same and there's no possible mistake in the interpretation of the displayed emojis.

One question:

The first emoji doesn't even have the same name, ok I think in both cases it's a wrench but it's a bit confusing. Should I really accept the verification?

I think I'm being annoying with little details, and in that case I'll guess the verification is ok and I can accept it, but in such case of verifying keys for encryption, I would prefer not guess but feel sure.

Version information

t3chguy commented 5 years ago

This probably warrants riot-ios and riot-android using Twemoji as riot-web does for consistency

t3chguy commented 5 years ago

This issue can probably be closed in favour of https://github.com/vector-im/riotX-android/issues/198 once a matching one is made for riot-ios

eauchat commented 5 years ago

Hey, thanks for the link. But how come the emojis are not even having the same name (the first one at least in the screenshots I provided)? Is that normal?

t3chguy commented 5 years ago

Emoji naming in riot-web comes from https://www.npmjs.com/package/emojibase-data which is not usable by ios and android so some source of emoji names must be wrong