search

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
68 stars 11 forks source link

Notifications optional toggle to disable mentions on mxid localpart only, but retain mentions #2160

Open metal0 opened 10 months ago

metal0 commented 10 months ago

Your use case

What would you like to do?

I would like to not be mentioned/pinged when someone uses my mxid localpart (and not a mention).

Why would you like to do it?

I'm in a lot of matrix rooms, and my username happens to be a common english word, if i enable notifications on "Notify when someone mentions using @displayname or @ mxid", I will also get mentioned when someone simply types out my mxid localpart. There is no current way as far as I can tell, either with old notifications or beta notifications to retain mentions (and replies) actually creating a notification while disabling this setting.

How would you like to achieve it?

Ideally, it would be nice if the "Notify when someone mentions using @displayname or @ mxid" setting actually worked the way it's described and not also notify you when someone just uses your mxid localpart, since a user can just easily add a keyword notification trigger for their own localpart if they wanted it to behave like this. Alternatively, a optional toggle to disable this behavior would also be nice.

Have you considered any alternatives?

I did find a way around this using keywords, by adding all possible formatting of mentions of my full mxid, but that system then prevent replies from working (since it seems that keywords only checks message body which in some scenarios of message replies will not contain any part of my username)

Additional context

No response

clokep commented 10 months ago

I think this is fixed by intentional mentions (MSC3952)?

metal0 commented 10 months ago

I think this is fixed by intentional mentions (MSC3952)?

certainly seems like it. I've been reading up on your Synapse implementations of this as well, however I cannot comprehend if backwards compat was ever finished up for the implementations. I apologize if this is offtopic (I am only now realizing the scope of this "issue"), but a message which contains my mxid's localpart in content.body of a message's event is still pinging/mentioning me, even on latest synapse release (which should include all your PRs and official support for your MSC). Again I'm sorry if there's some critical information I'm missing here, I'm still new to Matrix but from the information I've gathered it seems to me that backward compat isn't yet implemented (?)

clokep commented 10 months ago

I've been reading up on your Synapse implementations of this as well, however I cannot comprehend if backwards compat was ever finished up for the implementations.

It is backwards compatible, but if folks are using old clients then you'll still get pinged the "old" way. Only users of newer clients (which send the new m.mentions field) will the new logic kick in. (This was a tradeoff of getting it out somewhat quickly without completely breaking legacy clients.) I think currently Element Web and Element X both support the new behavior.

metal0 commented 10 months ago

Hmm, I'm unsure what's happening, then, I've tested this behavior with 2 different accounts on my HS (Synapse 1.95.0), both with the exact same notifications setting, and I'm seeing the same behavior on both. (Both clients are Element v1.11.46 Desktop & Web, which I believe to be the same, and using the new Notifications Beta Labs)

Disabling the "Notify when someone mentions using @displayname or @mxid" seems to still toggle this behavior.