element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
68 stars 11 forks source link

[Story] Show setting for dark mode / light mode in advanced user settings #2185

Closed VolkerJunginger closed 7 months ago

VolkerJunginger commented 9 months ago

Story

As a user that is a bit emotional in wintertimes I want to change the appearance of Element X to dark mode so that I can make Element X "wear black on the outside because black is how I feel on the inside".

Dependencies

Sign-offs

Android

iOS

Scope

### Android
- [x] Verified with build in screen reader
- [ ] https://github.com/vector-im/element-x-android/issues/1499
### iOS
- [x] Verified with build in screen reader
- [ ] https://github.com/vector-im/element-x-ios/issues/2083

Out of scope

kittykat commented 9 months ago

"Appearance: system" doesn't really mean anything to me as a user. Can we use strings like "Theme", "Match system", (and existing ones like "Light" and "Dark")?

It feels like it follows an iOS pattern right now. Android has the word "theme" in the strings to disambiguate what they are about.

stefanceriu commented 9 months ago

"Appearance: system" doesn't really mean anything to me as a user.

  • That seems to be a normal Apple design choice
Screenshot 2023-11-27 at 12 30 07

Can we use strings like "Theme" I don't think we can because this is not a theme. It again follows Apple's choice of word

Screenshot 2023-11-27 at 12 33 39
kittykat commented 9 months ago

I wonder if this is one of the places where it makes sense to differentiate between Android and iOS because the system default is quite different.

ooi, based on the screenshot you shared above, does it make sense to use "Auto" instead of "System"?

stefanceriu commented 9 months ago

does it make sense to use "Auto" instead of "System"

Auto makes sense for the system as it will compute it based on the time of the day. It doesn't for us as we just follow the system.