element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
68 stars 11 forks source link

[Story] Mark a room or dm as favourite #2197

Closed VolkerJunginger closed 6 months ago

VolkerJunginger commented 9 months ago

Description

As a user that has favourite room I want to mark these as favourites so that I can find the fast.

Figma

Acceptance criteria

Leads

Size estimate

S/M/L

Dependencies

Out of scope

Open questions

### Questions

Subtasks

### Android
- [ ] https://github.com/element-hq/element-x-android/issues/2208
### iOS
- [ ] https://github.com/element-hq/element-x-ios/issues/2320
### Rust
- [ ] https://github.com/matrix-org/matrix-rust-sdk/issues/3005
### Other

Sign-off

Android

iOS

jplatte commented 9 months ago

Favorite rooms are stored under m.favourite room account data. This should be pretty easy to integrate into RoomInfo on the Rust side, and expose to EX.

manuroe commented 7 months ago

@amshakal we would need some guidance on the design. Legacy apps do not have the same behavior.

amshakal commented 7 months ago

Not sure about adding a star to the room header but lets start with adding a button in the room details page. I added designs for it. I am slightly skeptical of changing the copy from favourite to un-favourite like we do for mute, unmute as the word is too long so would like to check if thats okay with everyone. Mark room as favourite:

Screenshot 2024-01-09 at 4 59 00 pm

Mark DM as favourite:

Screenshot 2024-01-09 at 4 59 05 pm