element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
68 stars 11 forks source link

[Story] User detail view: Show "1:1" chat button #2207

Closed VolkerJunginger closed 7 months ago

VolkerJunginger commented 9 months ago

Story

As a user that is visiting an other users detail view I want to have an easy way to start a 1:1 conversation so that I can start chatting.

Dependencies

Sign-offs

Android

iOS

Scope

### Android
- [ ] https://github.com/vector-im/element-x-android/issues/1915
### iOS
- [ ] https://github.com/vector-im/element-x-ios/issues/2179

Out of scope

manuroe commented 9 months ago

We would need canonical DM to implement it correctly.

The legacy apps have a list of DMs on this screen:

Image

ganfra commented 9 months ago

@manuroe So what is the status about this ticket?

manuroe commented 9 months ago

We want to reuse the mechanism that is used when creating a DM. If the user tries to create a DM with someone with an already existing room, the app jumps to this room instead of creating one. It means we are going to display only one room, the one the existing algorithm provides.

@VolkerJunginger, can you confirm this?

ganfra commented 9 months ago

Also, when opening the DM, where back navigation should lead? to the RoomMemberDetails? to the RoomList?

manuroe commented 9 months ago

@amshakal what do you think ^?

VolkerJunginger commented 9 months ago

We want to reuse the mechanism that is used when creating a DM. If the user tries to create a DM with someone with an already existing room, the app jumps to this room instead of creating one. It means we are going to display only one room, the one the existing algorithm provides.

@VolkerJunginger, can you confirm this?

yes.

VolkerJunginger commented 8 months ago

@amshakal Could yo test this? I think the button is wrong

VolkerJunginger commented 7 months ago

@stefanceriu iOS is using an other string than Android.

stefanceriu commented 7 months ago

@VolkerJunginger

iOS is using an other string than Android.

Are you sure about that? To me, they both seems to use Direct chat: iOS vs. Android

VolkerJunginger commented 7 months ago

The iOS app does show an english text - Android is German. So something must be off.

stefanceriu commented 7 months ago

Oh, so they're not using different strings, it's just that iOS is missing some translations.

Will be fixed in element-hq/element-x-ios/pull/2288 (https://github.com/element-hq/element-x-ios/pull/2288/files#diff-9c27e8b707146678ab814769be3d29a8f93eef6e475491af0a2a15e884db270bL112)

VolkerJunginger commented 7 months ago

We're closing this. Design changes might come w. another ticket