element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
72 stars 12 forks source link

Android: Don't crop pictures in the timeline #2214

Closed VolkerJunginger closed 9 months ago

VolkerJunginger commented 10 months ago

Story

Pictures are cropped on top and bottom in the timeline. This should not be the case.

Dependencies

Sign-offs

Android

Scope

### Android
- [ ] https://github.com/vector-im/element-x-android/issues/1940

Out of scope

pixlwave commented 10 months ago

Late follow-up from the discussion this morning, here is the logic we use on iOS. Completely forgot we have a minHeight too: TimelineMediaFrame.swift

manuroe commented 10 months ago

I confirm that a screenshot from an iPhone 13 is not fully rendered in the timeline on EXA. It is normal to protect the rendering in the timeline.

Let's align Android with iOS as a minimum.

Android algo: https://github.com/vector-im/element-x-android/blob/develop/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemAspectRatioBox.kt#L28

manuroe commented 9 months ago

We need design feedback on https://github.com/element-hq/element-x-android/pull/1941

bmarty commented 9 months ago

Done, ready to be tested