Remove extra logout screen

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients

66 stars 11 forks source link

Remove extra logout screen #2249

Closed VolkerJunginger closed 7 months ago

VolkerJunginger commented 7 months ago

Your use case

Go to setting and tap "log-out". The app is opening an extra screen. The user has to tap "Log-Out" again. A pop-up is shown: "are you sure you want to logout?"

Expectation:

Do not show the extra screen
Show the pop-up right away (same as iOS)

Have you considered any alternatives?

No response

Additional context

No response

VolkerJunginger commented 7 months ago

@amshakal Do you agree or was there any meaningfull reason to show the extra screen?

amshakal commented 7 months ago

I think it's fairly normal to have an 'are you sure' alert for signing out, specially in our case where signing in can mean going through the whole OIDC flow again, or worse, doing verification again. We should avoid having people sign out.

amshakal commented 7 months ago

I do however think that having sign out inside settings is fine but we dont need to make it prominent in the context menu on iOS

VolkerJunginger commented 7 months ago

Ok, lets keep the alert but remove the extra page on Android.

VolkerJunginger commented 7 months ago

Will be done w. https://github.com/element-hq/element-x-android/issues/2072