search

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

New design for the @ mention pills #2439

Open DantrazTrev opened 3 years ago

DantrazTrev commented 3 years ago

Is your suggestion related to a problem? Please describe.

The @ mention pills and the room reference look nearly identical to the room reference

image

There is only one visible distinction of a trailing : that is added if the mention is at the start and is removable.

Describe the solution you'd like.

A redesign for the @ pills that are a bit more distinguishable maybe remove the background and make it bolder?

image

Describe alternatives you've considered.

Not really sure about the designs so there should be better ones than the suggested

MadLittleMods commented 1 year ago

This may only be a problem with dark theme.

The contrast and differentiation in the light theme seems adequate to me.

For reference, pills just got a fresh new update: https://github.com/matrix-org/matrix-react-sdk/pull/10417 but I don't think that addressed dark theme colors/contrast.

weeman1337 commented 1 year ago

Recent changes did only update the pill logic not the UI. As far as I know, pills should get a new UI when iterating Element X designs.