search

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

Invisible Crypto: A clearer message to the user when sending fails due to their own unverified devices #2534

Closed mxandreas closed 1 month ago

mxandreas commented 2 months ago

Description

On our way to invisible crypto (in which all users devices are either fully verified or fully ignored) we have implemented a stop-gap solution for security purposes:

Given Alice has explicitly verified Bob's identity And Bob has unverified devices When Alice is trying to send a message to Bob Then The message fails to send And Bob needs to take an action to decide what will happen next.

The visuals look as follows:

image image

It was not realized that the same will happen when Alice == Bob, meaning that user's own devices aren't verified. For security reasons this needs to remain, as otherwise one could inject a device on behalf of the user and start listening to their messages without the user noticing that. However, to make this more user friendly, the text of the message to the user should be changed so that it is clearer for them what is happening.

Proposed copy of the message when its the user's own device that is unverified.

Title: Your message was not sent because you have not verified one or more of your devices Description: One or more of your devices are unverified. You can send the message anyway, or you can cancel for now and try again later after you have verified all of your devices.

Links to the design in Figma for convenience.

Acceptance criteria

Leads

Size estimate

None

Dependencies

Out of scope

Open questions

### Questions

Subtasks

### Android
- [ ] https://github.com/element-hq/element-x-android/issues/3484
### iOS
- [ ] https://github.com/element-hq/element-x-ios/issues/3350
### Rust
### Other

Sign-off

Android

iOS

mxandreas commented 2 months ago

@americanrefugee Could you please review the copy I suggested and then add the corresponding variant also into Figma. If you need further clarifications, let me know.

americanrefugee commented 2 months ago

Here is the design for iOS and Android

manuroe commented 1 month ago

The update has been done both on Android and iOS. It was part for the releases we made for the Matrix Conf. Can we close this issue?

mxandreas commented 1 month ago

Done