Rename "invisible crypto" config setting to something else we agree on

element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients

75 stars 12 forks source link

Rename "invisible crypto" config setting to something else we agree on #2536

Closed andybalaam closed 1 month ago

andybalaam commented 1 month ago

### Tasks
- [ ] https://github.com/element-hq/element-x-ios/issues/3322
- [ ] https://github.com/element-hq/element-x-android/issues/3528

pmaier1 commented 1 month ago

Proposal

Ignore unverified devices when sending/receiving messages

richvdh commented 1 month ago

The js-sdk exposes a separate mode called "transition mode". Apparently this means:

Encryption will throw an error if a verified user has an unsigned device, or if a verified user replaces their identity.
Events are decrypted only if they come from cross-signed devices, or devices that existed before the Rust crypto SDK started tracking device trust: other events will result in a decryption failure.

(See https://github.com/matrix-org/matrix-js-sdk/pull/4407)

Now that I look at that list, I can't see why it would ever be useful. @BillCarsonFr: any ideas?

richvdh commented 1 month ago

We're doing some brainstorming to figure out what we actually want here

richvdh commented 1 month ago

Now that I look at that list, I can't see why it would ever be useful. @BillCarsonFr: any ideas?

After discussion: we believe that we do not need a separate "transition mode" at the application level, but we do need some flexibility at the js-sdk level. We'll need some changes to the current js-sdk impl though: https://github.com/matrix-org/matrix-js-sdk/issues/4428.

richvdh commented 1 month ago

Following a suggestion by @mxandreas, I think we're instead converging on:

Exclude insecure devices when sending/receiving messages

BillCarsonFr commented 1 month ago

Following a suggestion by @mxandreas, I think we're instead converging on:

Exclude insecure devices when sending/receiving messages

Right, will update EIX/EAX side when doing https://github.com/element-hq/crypto-internal/issues/353 and https://github.com/element-hq/crypto-internal/issues/354

BillCarsonFr commented 1 month ago

Following a suggestion by @mxandreas, I think we're instead converging on:

Exclude insecure devices when sending/receiving messages

Right, will update EIX/EAX side when doing element-hq/crypto-internal#353 and element-hq/crypto-internal#354

In review in https://github.com/element-hq/element-x-ios/pull/3358 and https://github.com/element-hq/element-x-android/pull/3569