element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
74 stars 12 forks source link

[Story] Improve user guidance during QR code login #2558

Open mxandreas opened 2 weeks ago

mxandreas commented 2 weeks ago

Description

Currently the scanning the QR code with EX and showing the QR code on EW device for login are only available on the nightly builds. The reason for that is that MAS (which is a prerequisite for the QR code login) is not yet available in most homeservers.

However, it is assumed that deploying MAS on various homeservers will span across a long period of time (and some homeservers may not ever get it), it is desired to make it more clear for the users that this function depends on something their homeserver does not (yet) have.

In iterations with @amshakal @americanrefugee we landed on the following:

This would allow us to release the QR code login in the publish/production versions.

Acceptance criteria

No response

Leads

Size estimate

S

Dependencies

Out of scope

Open questions

### Questions

Subtasks

### Android
- [ ] https://github.com/element-hq/element-x-android/issues/3632
- [ ] https://github.com/element-hq/element-x-android/pull/3646
### iOS
- [ ] https://github.com/element-hq/element-x-ios/issues/3385
- [ ] https://github.com/element-hq/element-x-ios/pull/3392
### Web
- [x] https://github.com/element-hq/matrix-react-sdk/pull/147
- [ ] Make the "Link new device" available in production release

Sign-off

Android

iOS

pmaier1 commented 2 weeks ago

Makes sense to me (apart from the fact that only a tiny fraction of users out there use a homeserver that actually supports QR code login :man_shrugging:).

mxandreas commented 2 weeks ago

@americanrefugee Has done the design updates for both EX and EW side:

image

bmarty commented 1 week ago

I have added the string screen_qr_code_login_initial_state_subtitle to localazy (@element-hq/element-x-ios-reviewers)

mxandreas commented 1 week ago

For visibility. It was confirmed that the desired changes on EW take more effort (and can't be released as part of the security release) due to the fact that we can't simply un-lab all the functionality (and need to do it just for the QR code parts).

Since it is now known that this is overall feasible (just delayed by a week), I proposed we continue with the release of EX as planned (e.g. showing the QR code login button), given we have a warning/hint that it needs to be supported by the account provider.

cc @daniellekirkwood @manuroe @t3chguy @pmaier1