element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

[Story] Accepting & declining requests to join #2580

Open mxandreas opened 1 month ago

mxandreas commented 1 month ago

Description

Accepting an individual request

Accepting all requests

Declining an individual request

Declining an individual request & banning the person

Conditions:

Designs:

Acceptance criteria

Size estimate

None

Dependencies

Out of scope

Open questions

### Questions
- [x] If one is changing the room’s join rules (especially to public or restricted), would accepting (e.g. an invite is sent) or declining still work “gracefully”.
- [x] How to also ban the user when declining their request - just needs designs.
- [ ] How to remember if admin/moderator has seen (and postponed the decision) a request. Largely a technical question but we may have solution which is local vs. works across clients.

Subtasks

### Android
### iOS
### Rust
### Other
- [ ] https://github.com/element-hq/synapse/issues/17929
mxandreas commented 2 weeks ago

@ganfra @gaelledel We had a discussion with @Velin92 and @jmartinesp that we should also have an option to ban the user when their request is being declined. I am afraid that this is going to cause friction if we do not have it. Fortunately, this is easy to do from engineering side, so the only thing is to see how to fit this into the designs, e.g. perhaps just have 3rd option "Decline & ban" in the confirmation modal.

mxandreas commented 2 weeks ago

@ganfra @gaelledel We had a discussion with @Velin92 and @jmartinesp how to remember if the admin/moderator has seen a request in the room (in the banner) and has dismissed/postponed it. We have to remember it, to make sure that the banner does not come up multiple times for the same request.

It is largely a technical question, however, depending on the solution, the behavior may differ for the user a bit:

If there is no major difference in effort then the global solution is preferred.

mxandreas commented 1 week ago

Concluded that we will have the option to Decline & Ban - Gaelle is adding the designs now.