As a user who has opened a private room in a preview (e.g. via a link)
I want to be aware that I may not be able to join this room
So that I would not think it is a technical error; and spend time on solving it
This is not a problem that is directly related to requesting access to a room; it is one that already exists and caused by the fact that the join rules of a private room are not accessible to a user that has no membership with the room. This could be a room which requires an invite (e.g. the user can't join anyway) but it also could be a restricted room (accessible to space members) in which case the user may be able to join. Theoretically, it could be also a knock room, but for not increasing the confusion further, Element clients currently will prevent creating private room with knock.
As there may be potentially a case where user can join, we are optimistically currently showing a button to do that. This will continue to be so but we will make 2 UI adjustments to set the expectations more clearly:
Tell to the user that - e.g. "This looks to be a private room, and you either may need an invite or be part of a space"
When joining fails, show a user-friendly error message to make it clear that this was not a temporary technical fault or bug - e.g. "Unable to join the room. It seems like this room requires an invite or that you’re a member of a space"
The designs and exact copy are TODO.
Acceptance criteria
The user understands that joining may fail and the reasons for it.
Description
This is not a problem that is directly related to requesting access to a room; it is one that already exists and caused by the fact that the join rules of a private room are not accessible to a user that has no membership with the room. This could be a room which requires an invite (e.g. the user can't join anyway) but it also could be a restricted room (accessible to space members) in which case the user may be able to join. Theoretically, it could be also a knock room, but for not increasing the confusion further, Element clients currently will prevent creating private room with knock.
As there may be potentially a case where user can join, we are optimistically currently showing a button to do that. This will continue to be so but we will make 2 UI adjustments to set the expectations more clearly:
The designs and exact copy are TODO.
Acceptance criteria
Size estimate
None
Dependencies
Out of scope
Open questions
Subtasks