element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
75 stars 12 forks source link

option to hide NSFW rooms in directory #282

Open uhoreg opened 7 years ago

uhoreg commented 7 years ago

probably involving some sort of public tagging of rooms (though probably not called tags, since we already have room tags), and filtering the room directory based on tags

Valodim commented 7 years ago

Beware of overengineering: Simply filtering by NSFW keyword in the title might be a perfectly valid utility/effort tradeoff.

turt2live commented 7 years ago

Related: https://github.com/vector-im/riot-web/issues/4286

lampholder commented 7 years ago

I think this would be a really good thing to do (P3 just because as far as I'm aware it's not currently on our active agenda).

uhoreg commented 7 years ago

Beware of overengineering: Simply filtering by NSFW keyword in the title might be a perfectly valid utility/effort tradeoff.

A lot of NSFW rooms don't have "NSFW" in the room name, and filtering rooms that have "NSFW" in the topic will filter out rooms that say, e.g. "NSFW Uploads are banned" (#jupiterbroadcasting:matrix.org) or "Tag NSFW stuff" (#_foonetic_xkcd-compsci:matrix.org).

ara4n commented 7 years ago

i'm hearing instances of people who don't recommend Riot because of the NSFW rooms in the matrix.org roomdir. One solution is just to remove them from the list for now, but i'd rather fix this at higher priority. +1 to not overengineering it for now; although it does need an explicit tag on the room somehow rather than the 'look for NSFW in the topic'.

rodneyrod commented 7 years ago

I feel that this issue could be solved on the user end with custom tags, mentioned here: https://github.com/vector-im/riot-web/issues/1373

Custom tags could include a NSFW option for the group that the user could check.

uhoreg commented 7 years ago

The tags referred to in vector-im/element-web#1373 actually are per-user tags (like the "Favourites" and "Low Priority" that you see in the left-hand side bar), so wouldn't really help with this issue. But some other global room tagging system might work (which is actually what I suggested in my first comment).

BloodyIron commented 5 years ago

Is this still a thing? Close maybe?

turt2live commented 5 years ago

we don't have this filter yet, so we shouldn't close it.

BloodyIron commented 5 years ago

Last update before my message was 2017 though, and this is marked "p1", is this actually a critical thing? If not, p1 seems overstating it.

turt2live commented 5 years ago

Our README describes our prioritization process. Let's not fill this issue with that discussion though.

ghost commented 4 years ago

although it does need an explicit tag on the room somehow rather than the 'look for NSFW in the topic'.

Rooms with pornographic icons are showing up in the list right now. A "show porn" box in the search, mercifully unchecked by default, is going to become a necessity as Matrix gains traction.

BloodyIron commented 4 years ago

Not everything NSFW is pornographic, categorising like that is not going to be the blanket solution.

omentic commented 3 years ago

I don't think a tag-based system is the right way forward here. Room admins as a whole can't be relied on to tag NSFW rooms to the degree fixing search would require, and manually tagging would put a large maintenance burden on the Matrix developers.

Since this is a blocker to recommending Element to friends and family for many people (myself included), I think the benefits of a quick-and-dirty keyword filter (no pornographic pictures in innocuous / literally all searches) would outweigh the detriments (the small number of SFW rooms erroneously filtered). Those SFW-filtered rooms could be added to a whitelist if they're of a certain size, change their descriptions, or just live with being invisible in search results.

geckolinux commented 2 years ago

How about just a simple option to disable the browsing of public rooms? Thanks for considering this.

t3chguy commented 2 years ago

How about just a simple option to disable the browsing of public rooms? Thanks for considering this.

This option is up to your server admin.

SimonBrandner commented 2 years ago

How about just a simple option to disable the browsing of public rooms? Thanks for considering this.

This option is up to your server admin.

Well, you can always do that client-side but I don't feel like it's not a good solution

geckolinux commented 2 years ago

How about just a simple option to disable the browsing of public rooms? Thanks for considering this.

This option is up to your server admin.

Hmm, that feels backwards to me. The whole reason that this improvement is desired is because there are many NSFW rooms in the large public Matrix servers that most "normal" users register on, and those servers will never disable browsing for public rooms. Whereas if it were a small locally controlled Matrix server with an accessible admin then there likely wouldn't be inappropriate rooms on it anyway.

In the most common usage scenario that I see, "non-techie" users prefer Element with the default matrix.org server, and they almost exclusively use it for 1-on-1 chats or private groups. So simply an option to disable Element's "Explore Public Rooms" panel seems like a quick and easy solution so that individual users can choose to disable it instead of requiring them to deal with the server admin.