element-hq / element-meta

Shared/meta documentation and project artefacts for Element clients
70 stars 12 forks source link

Add dark mode to location sharing #626

Open HarHarLinks opened 2 years ago

HarHarLinks commented 2 years ago

Your use case

What would you like to do?

Use dark theme in element including location sharing

Why would you like to do it?

not burn my eyes when viewing a shared location

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

mnaturel commented 2 years ago

Hi @HarHarLinks, thanks for submitting this idea. To fully understand your suggestion, could you detail what changes you would like to see concerning the location sharing style? The app currently supports "Dark mode" when enabled on the device. Are you suggesting the map should also be in dark style? If so, I see an example of dark style in the mapTiler SDK we are currently using.

HarHarLinks commented 2 years ago

Are you suggesting the map should also be in dark style?

exactly.

Currently it looks like this (map tiles are in light mode regardless of app being in dark mode): image image

While the suggestion you linked goes in the right direction, I would prefer for it to use some muted dark colors.

image

There is this other issue of black to black text (in case tiles don't load) that only becomes visable when tapping it:

https://user-images.githubusercontent.com/2803622/189618919-a70d8691-f7ef-4695-a7b4-138bb04cf5ff.mp4

image

HarHarLinks commented 2 years ago

This is also generally a meta issue, e.g. desktop is using light mode tiles in dark mode element, too.

mnaturel commented 2 years ago

This is also generally a meta issue, e.g. desktop is using light mode tiles in dark mode element, too.

Thanks for explaining your request. I have moved the issue in meta repository so that it can be discussed accross the whole Element ecosystem. And design team should be involved in this discussion.

janogarcia commented 1 year ago

@rufuskahler Reassigning to @gaelledel, who is actively working on this project.

gaelledel commented 1 year ago

I am not sure that the mapping service we are using makes Dark mode maps available. @Johennes @jakewb-b This is a question for one of you.

Johennes commented 1 year ago

Maptiler does seem to support dark mode maps in general, yes: https://www.maptiler.com/maps/#basic-v2-dark//vector/4/13/49

I suppose we might have to set up separate style.json files for both modes and then dynamically switch between them. That would also require a spec change as the tile URL is in .well-known.