element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.13k stars 1.98k forks source link

Need to tap on a room twice to view it (using Riot-Web on and iPad). #12202

Open bwinton opened 4 years ago

bwinton commented 4 years ago

Description

I'm testing out Riot-Web on Mobile Safari on an iPad, and whenever I tap a room to view it, it shows the ⠇button, but doesn't show the contents of the room.

Steps to reproduce

I expect it to show the contents of the room. Instead it shows the ⠇button. 🙂

Logs being sent: no

Version information

For the web app:

t3chguy commented 4 years ago

How else would a widget with both an on-hover and on-click behaviour function on a touchscreen which cannot detect hover? This is not a riot specific thing, just how your browser is deciding to handle the lack of hover support.

bwinton commented 4 years ago

What on-hover functionality is it exposing? Is that functionality more important than what I thought would be the more common task of switching rooms?

t3chguy commented 4 years ago

It is the only way to access its context menu:

image

bwinton commented 4 years ago

What about showing the context menu when the room is selected instead? Do people change settings without entering the room that often?

t3chguy commented 4 years ago

That'd be undesirable in terms of design for users of mice, for touch-only devices sure it makes sense but what about then for touchscreen laptops which also have pointers and are hover-capable? Riot doesn't try to be touch compatible in many places

bwinton commented 4 years ago

If it was done on a touch-event instead of a click-event, then it shouldn't be much of a problem.

Also, if we're going to be offering the web version to people on iPads, as mentioned in https://github.com/vector-im/riot-web/issues/10863#issuecomment-580945792 then perhaps adding touch-compatiblity in some of the more common places should be a goal… ¯_(ツ)_/¯

t3chguy commented 4 years ago

Sure, that'd solve the two-tap issue but not the selected room should have the context menu trigger exposed (it'd only be exposed until you tap somewhere else)

Safari on iPad lies and claims it is a full-blown Mac OSX device running Safari which it is not as you have found with this issue

jryans commented 4 years ago

Also, if we're going to be offering the web version to people on iPads, as mentioned in #10863 (comment) then perhaps adding touch-compatiblity in some of the more common places should be a goal… ¯(ツ)

We'll have to work out how we want to handle touch-specific things like that, yes.

I am in the process writing up a more detailed proposal for the Riot core team on what our level of support here should be, so that should help us answer questions like this.