Can react twice with the same emoji

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.28k stars 2.03k forks source link

Can react twice with the same emoji #13586

Closed tredondo closed 4 years ago

tredondo commented 4 years ago

You can react to the same message with the same reaction twice: once by choosing the emoji from the picker, and once from the Quick Reactions. But if you hover over them, they show the same code.

Riot 1.6 web.

turt2live commented 4 years ago

Duplicate of https://github.com/vector-im/riot-web/issues/11161

t3chguy commented 4 years ago

This is not the same. That issue is duplicated counts within a key, this is unprintable unicode chars not being filtered out so they key differently.

dud1337 commented 4 years ago

Edit: Perhaps this is feature to enable "two thumbs up/down"-ing :smiley_cat:

Not all quick reactions have this bug.

Buggy:

:thumbsup:
:thumbsdown:

Safe:

:happy:
:tada:
:confused:
:heart:
:rocket:
:eyes:

A quick way to test UI-wise is by selecting, say, :happy: from quick-reactions, then searching for it in the main selector, and seeing it already selected. (Light blue underline in image above)

Then repeat the process for :thumbsup:. One will see it is not selected in the selector. (Pink underline in image above)

t3chguy commented 4 years ago

This is now fixed on develop by https://github.com/matrix-org/matrix-react-sdk/pull/4707 for outbound reactions. If you click on an existing reaction which has some invisible unicode then riot will match that invisible unicode and thus you could end up with loads of mismatched thumbs up.